2.850 - IK vs SS

[renew]

Here are two bugs we found in the last BP MightyOak vs BP renew game.

T4: IK attacks Victor. I don't see Victor's health go down by 2, although MightyOak does.
T5: IK attacks Victor. I do see the health go down, but until the end of the game I'll see 2 extra hp for Victor. On my screen, the game ended when he got me down to 2 hp.
T7 or so: IK attacks Victor who has SS: IK isn't dealt any dmg so doesn't die, but SS heals Victor. This is only with IK, not higher hp allies. SS seems to consider IK to be dead.

[Mightyoak713]

confirmed. also..makes it damn hard to kill someone when they heal 6 health every turn I use ik to wear dura. I had two out at one point...

[Twio]

Yay, time to ban Karash until the next update.

How does this even happen? Neither of those cards are even from SF.

[chanson311]

They finally figured out how to buff Gwen!

[Daemon Rayge]

Yay, time to ban Karash until the next update.

How does this even happen? Neither of those cards are even from SF.

I think they re-coded certain interactions that affected when damage is actually dealt. However, SS must have something that does not 100% work with it.

[Twio]

However, SS must have something that does not 100% work with it.

Or potentially Karash

[Gondorian]

To bring all the "kills" stuff into line with SRO order and also fix the long-standing issue with Karash's damage reduction timing, both cards had to be changed. There was no unit test for both together, and I guess no one ran into this interaction on test server, so it's a new bug that will surely get a new unit test when fixed.

[Gondorian]

UPDATE: I think the fix is simple, and I've just made an untested patch for Kyle that should do the trick (I can see the code where I am on holiday, but can't run Unity). I feel bad I introduced this one, but hopefully he can sort it for 2.85.